[coreboot] [commit] r5097 - in trunk/src: mainboard/amd/norwich mainboard/olpc/btest mainboard/olpc/rev_a southbridge/amd/cs5536

[Edwin Beasant]

No problem, I'll see what I can do :-)
Edwin

-----Original Message-----
From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org] On Behalf Of Peter Stuge
Sent: 09 February 2010 10:40
To: coreboot at coreboot.org
Subject: Re: [coreboot] [commit] r5097 - in trunk/src: mainboard/amd/norwich mainboard/olpc/btest mainboard/olpc/rev_a southbridge/amd/cs5536

repository service wrote:
> +++ trunk/src/mainboard/amd/norwich/romstage.c        Tue Feb  9 11:22:33 2010        (r5097)
..
> -     cs5536_setup_onchipuart();
> +     cs5536_setup_onchipuart(1);

> +++ trunk/src/southbridge/amd/cs5536/cs5536_early_setup.c     Tue Feb  9 11:22:33 2010        (r5097)
..
> +void cs5536_setup_onchipuart(int uart)
> +{
> +     switch (uart) {
> +     case 1:
> +             cs5536_setup_onchipuart1();
> +             break;
> +     case 2:
> +             cs5536_setup_onchipuart2();
> +             break;
> +     }
> +}

If you have an opportunity to revisit this then I think it would be
nicer to just remove this extra function and call the actual setup
functions directly.


//Peter

--
coreboot mailing list: coreboot at coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot