[coreboot] patch: enable spd for dram on s1850
ron minnich
rminnich at gmail.com
Fri Oct 9 22:08:17 CEST 2009
On Fri, Oct 9, 2009 at 12:36 PM, Myles Watson <mylesgw at gmail.com> wrote:
>> pnp_set_logical_device(dev);
>> - pnp_set_enable(dev, 0);
>> +/* don't disable for now, it kills serialice */
>> + pnp_set_enable(dev, 1);
>> if (iobase)
>
> I don't think this piece should be committed. It looks like it is
> just for debugging, and should stay local. A comment like /* Don't
> disable this if you're using SerialICE. */ might still make sense.
>
> Acked-by: Myles Watson <mylesgw at gmail.com>
I did not commit that piece. All others:
Committed revision 4755.
\
More information about the coreboot
mailing list