[coreboot] patch: enable spd for dram on s1850

Myles Watson mylesgw at gmail.com
Fri Oct 9 21:36:06 CEST 2009


>  	pnp_set_logical_device(dev);
> -	pnp_set_enable(dev, 0);
> +/* don't disable for now, it kills serialice */
> +	pnp_set_enable(dev, 1);
>  	if (iobase)

I don't think this piece should be committed.  It looks like it is
just for debugging, and should stay local.  A comment like /* Don't
disable this if you're using SerialICE. */ might still make sense.

Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles




More information about the coreboot mailing list