[coreboot] [Patch] CMOS: Add set_option and rework get_option.

Peter Stuge peter at stuge.se
Fri May 29 16:16:33 CEST 2009

Luc Verhaegen wrote:
> That was mighty fast :)

I read it through and I liked it.

> Since this changes "known" behaviour of cmos options, i would
> prefer at least a second Ack though, especially since the above
> reasoning might not be agreed with fully by all.


> A quick suggestion would be this:

Or store a 32 bit CRC in NVRAM, calculated from a canonicalized form
of the cmos.layout contents.

> Minor number should be bumped on additional entries or additional
> values, so that only newer option tables (from cb tables or from
> cmos.layout) are allowed by nvram_tool.

Versioning is nice - but do we need it? I think this nvram stuff is
the most infrequent changing part of all of coreboot.


More information about the coreboot mailing list