[coreboot] [PATCH] flashrom: Use helper functions to access flash chips

Joseph Smith joe at settoplinux.org
Thu Mar 5 22:49:19 CET 2009

On Thu, 05 Mar 2009 14:16:08 +0100, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> flashrom: Use helper functions to access flash chips.
> Right now we perform direct pointer manipulation without any abstraction
> to read from and write to memory mapped flash chips. That makes it
> impossible to drive any flasher which does not mmap the whole chip.
> Using helper functions readb() and writeb() allows a driver for external
> flash programmers like Paraflasher to replace readb and writeb with
> calls to its own chip access routines.
> This patch has the additional advantage of removing lots of unnecessary
> casts to volatile uint8_t * and now-superfluous parentheses which caused
> poor readability.
> Please note that this patch works, but the conversion is not complete
> yet (reads outside assignments are not converted).
Thanks for laying down the foundation for Paraflasher Carl-Daniel :-)
I can't wait to get started. I just have to finish something else I am
working on then it will be go time.

Joseph Smith

More information about the coreboot mailing list