[coreboot] [PATCH] flashrom: Use helper functions to access flash chips

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Mar 5 20:26:20 CET 2009


On 05.03.2009 19:07, Carl-Daniel Hailfinger wrote:
> On 05.03.2009 15:45, FENG Yu Ning wrote:
>   
>> Carl-Daniel Hailfinger wrote:
>>
>>     
>>> I used the semantic patcher Coccinelle to create this patch.
>>>     
>>>       
>> Acked-by: FENG Yu Ning <fengyuning1984 at gmail.com>
>>   
>>     
>
> Thanks!
>
> I'll commit shortly. Below is the updated patch which performs the
> conversion completely. And the semantic patch shrunk quite a bit.
> @@
> expression a;
> typedef uint8_t;
> volatile uint8_t *b;
> @@
> - *(b) = (a);
> + writeb(a, b);
> @@
> volatile uint8_t *b;
> @@
> - *(b)
> + readb(b)
> @@
> type T;
> T b;
> @@
> (
>  readb
> |
>  writeb
> )
>  (...,
> - (T)
> - (b)
> + b
>  )
>
> In contrast to a sed script, the semantic patch performs type checking
> before converting anything.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>   

Committed in r3971.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list