[coreboot] [PATCH 3/6] Intel EP80579 northbridge

Ed Swierk eswierk at arastra.com
Wed Sep 24 02:48:14 CEST 2008

On Tue, Sep 23, 2008 at 5:09 PM, Joseph Smith <joe at settoplinux.org> wrote:
> Wait, making a common file for this?
> struct dimm_size {
>        unsigned long side1;
>        unsigned long side2;
> };
> Four four lines of code that seems a little silly to me?

This was in response to Uwe's suggestion--he would rather move the
struct dimm_size to a common header file than duplicate it in numerous
intel raminit files. I could go either way; this is pretty minor
considering the overall level of redundancy in the northbridge code
but I can see not wanting to make things worse.

> Can you resend you patch, I don't think I got it.

Here it is (unchanged from my 3 Sept message).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ep80579-northbridge.patch
Type: application/octet-stream
Size: 24728 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080923/196009b4/attachment.obj>

More information about the coreboot mailing list