[coreboot] [PATCH 3/6] Intel EP80579 northbridge

Joseph Smith joe at settoplinux.org
Wed Sep 24 02:09:21 CEST 2008

On Tue, 23 Sep 2008 15:30:53 -0700, "Ed Swierk" <eswierk at arastra.com>
> On Wed, Sep 3, 2008 at 5:23 PM, Ed Swierk <eswierk at arastra.com> wrote:
>> Thanks for the feedback. I have addressed most of your comments;
>> please see the attached patch.
>> I will address your comment about the duplicate struct dimm_size
>> declaration separately. Would it make sense to put it in a file common
>> to all Intel northbridges, say, src/northbridge/intel/mem.h, and then
>> remove it from the various raminit.c's?
>> Signed-off-by: Ed Swierk <eswierk at arastra.com>
> Pinged-by: Ed Swierk <eswierk at arastra.com>
Wait, making a common file for this?

struct dimm_size { 
        unsigned long side1; 
        unsigned long side2; 

Four four lines of code that seems a little silly to me? Can you resend you
patch, I don't think I got it.

Joseph Smith

More information about the coreboot mailing list