[coreboot] [PATCH] v2: sb600: Fix I/O port variable size, simplify code

Uwe Hermann uwe at hermann-uwe.de
Tue Oct 21 18:33:06 CEST 2008

On Tue, Oct 21, 2008 at 10:12:43AM -0600, Marc Jones wrote:
>> I/O ports are 16bit, so change 'unsigned long port_base' to 'u16 port_base'.
>> Also, use more readable #defines instead of hardcoded config ports for
>> PM/PM2 related functions, and simplify them a bit.
>> Build-tested with the AMD dbm690t target.
>> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> Good stuff. Thanks!
> Acked-by: Marc Jones <marc.jones at amd.com>

Thanks, r3680.

I'll also do the same in v3 soonish.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list