[coreboot] [PATCH] v2: sb600: Fix I/O port variable size, simplify code

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Oct 21 18:42:09 CEST 2008


On 21.10.2008 18:33, Uwe Hermann wrote:
> On Tue, Oct 21, 2008 at 10:12:43AM -0600, Marc Jones wrote:
>   
>>> I/O ports are 16bit, so change 'unsigned long port_base' to 'u16 port_base'.
>>> Also, use more readable #defines instead of hardcoded config ports for
>>> PM/PM2 related functions, and simplify them a bit.
>>>
>>> Build-tested with the AMD dbm690t target.
>>>
>>> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
>>>       
>> Good stuff. Thanks!
>> Acked-by: Marc Jones <marc.jones at amd.com>
>>     
>
> Thanks, r3680.
>
> I'll also do the same in v3 soonish.
>   

Cool, thanks!

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list