[coreboot] [RFC] Here we go... the SLOF biosemu for coreboot-v3

Jordan Crouse jordan at cosmicpenguin.net
Fri Dec 12 19:34:41 CET 2008


Myles Watson wrote:
> 
>> -----Original Message-----
>> From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006 at gmx.net]
>> Sent: Friday, December 12, 2008 10:17 AM
>> To: ron minnich
>> Cc: Myles Watson; Pattrick Hueper; coreboot at coreboot.org
>> Subject: Re: [coreboot] [RFC] Here we go... the SLOF biosemu for coreboot-
>> v3
>>
>> On 12.12.2008 17:27, ron minnich wrote:
>>> On Fri, Dec 12, 2008 at 8:21 AM, Myles Watson <mylesgw at gmail.com> wrote:
>>>
>>>> Any comments from the rest of the list?  There's still some cleanup to
>> be
>>>> done, but it works as advertised.  I'll Ack it and commit it if no one
>>>> chimes in.
>>>>
>>>>
>>> have not had a chance to test. If it will do no harm I'm ok with it.
>>>
>> There might be a considerable size increase if we take into account that
>> our x86emu has been optimized for size by Ollie Lho.
> 
> I built qemu with and without the patch with the emulator x86emu.
> 
> For me it takes 200 bytes in stage2/segment1 and 11 bytes in
> stage2/segment2.
> 
> Since it implements a few new opcodes, that's not surprising.  I suppose we
> could make those opcodes dependent on using the new emulator, but it doesn't
> seem worth it.
> 
> With biosemu enabled, it takes just over 3K more in segment 1 and 31 bytes
> in segment 2.  As advertised: larger, but not huge.

And this code is arguably better and certainly more readable and 
hackable.  I think the size increase is worthwhile.

Jordan





More information about the coreboot mailing list