[coreboot] buildrom bug

[Jordan Crouse]

On 26/04/08 00:47 +0200, Peter Stuge wrote:
> On Fri, Apr 25, 2008 at 04:32:34PM -0600, Jordan Crouse wrote:
> > > > +CBV2MK-y=$(PACKAGE_DIR)/coreboot-v2/generic.mk
> > > > +CBV2MK-$(CONFIG_PLATFORM_NORWICH) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > > +CBV2MK-$(CONFIG_PLATFORM_MSM800SEV) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > > +CBV2MK-$(CONFIG_PLATFORM_ALIX1C) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > > +CBV2MK-$(CONFIG_PLATFORM_DB800) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > > +CBV2MK-$(CONFIG_PLATFORM_DBE61) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > 
> > > Why is this mapping needed here? Coreboot already knows that they are
> > > lx boards? Sorry, I am a total buildrom noob so will ask many
> > > questions and try to point out not obvious things.
> > 
> > No problem.   These are for platform specific magic that we need to 
> > do around the coreboot-v2 build, such as add different Config.lb files,
> > etc, etc.  All of the LX boards have the same platform specific magic
> > (add VSA), so they share a similar target.
> 
> My point is that buildrom is integrated fairly tightly with coreboot
> already and it should not need to duplicate this mapping between e.g.
> ALIX1C and geodelx.
> 
> For v3 read the dts. For v2, hm, maybe look for "cpu/amd/model_lx" in
> mainboard/v/b/Config.lb.
 
No - this is actually stuff external to coreboot itself.  In this
case its the code that appends VSA to the ROM.

it is named geodelx.mk because thats a handy name, not because there is
any sort of mapping.

-- 
Jordan Crouse
Systems Software Development Engineer 
Advanced Micro Devices, Inc.