[coreboot] buildrom bug

Peter Stuge peter at stuge.se
Sat Apr 26 00:47:23 CEST 2008


On Fri, Apr 25, 2008 at 04:32:34PM -0600, Jordan Crouse wrote:
> > > +CBV2MK-y=$(PACKAGE_DIR)/coreboot-v2/generic.mk
> > > +CBV2MK-$(CONFIG_PLATFORM_NORWICH) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > +CBV2MK-$(CONFIG_PLATFORM_MSM800SEV) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > +CBV2MK-$(CONFIG_PLATFORM_ALIX1C) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > +CBV2MK-$(CONFIG_PLATFORM_DB800) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > > +CBV2MK-$(CONFIG_PLATFORM_DBE61) = $(PACKAGE_DIR)/coreboot-v2/geodelx.mk
> > 
> > Why is this mapping needed here? Coreboot already knows that they are
> > lx boards? Sorry, I am a total buildrom noob so will ask many
> > questions and try to point out not obvious things.
> 
> No problem.   These are for platform specific magic that we need to 
> do around the coreboot-v2 build, such as add different Config.lb files,
> etc, etc.  All of the LX boards have the same platform specific magic
> (add VSA), so they share a similar target.

My point is that buildrom is integrated fairly tightly with coreboot
already and it should not need to duplicate this mapping between e.g.
ALIX1C and geodelx.

For v3 read the dts. For v2, hm, maybe look for "cpu/amd/model_lx" in
mainboard/v/b/Config.lb.

Or no?


> > >  	@ (size=`stat -c %s $<`; count=`expr $(GEODE_VSA_SIZE) - $$size`; \
> > > -	@ dd if=/dev/zero bs=1 count=$$count  >> $@ 2> /dev/null)
> > > +	dd if=/dev/zero bs=1 count=$$count  >> $@ 2> /dev/null)
> > 
> > On purpose?
> 
> yes - the @ is a makeism - the second @ was in the shell and
> freaking out sh.

Oh yes - good one.


//Peter




More information about the coreboot mailing list