[LinuxBIOS] [LinuxBIOSv2] WIP Support for RCA RM4100 - i82830 Complete

Corey Osgood corey.osgood at gmail.com
Tue Sep 18 05:45:22 CEST 2007

joe at smittys.pointclark.net wrote:
> Here you go Uwe,
> i82830 northbridge code is done. Works great. Note: Checkout the
> generic spd_get_dimm_size()function in raminit.c, there is a pretty
> cool way to get each side of a dimm's size only using SPD 5 and 31
> (original idea from Corey, Thanks). Works for dimms up to 2GB. Works
> on SDRAM and DDR, DDR2, maybe more.
> Signed-off-by: Joseph Smith <joe at smittys.pointclark.net>
> Acked-by: Joseph Smith <joe at smittys.pointclark.net>

Only minor, trivial fixes like whitespace fixes, grammer issues, etc,
are self-acked. Just a couple small issues:

> Property changes on: src/northbridge/intel/i82830/i82830.h
> ___________________________________________________________________
> Name: svn:executable
>    + *

All these need to go away, either edit the patch by hand or chmod -x them.

> Index: src/northbridge/intel/i82830/raminit.c
> ===================================================================
> --- src/northbridge/intel/i82830/raminit.c    (revision 0)
> +++ src/northbridge/intel/i82830/raminit.c    (revision 0)
> @@ -0,0 +1,489 @@
> +/*
> + * This file is part of the LinuxBIOS project.
> + *
> + * Copyright (C) 2007 Joseph Smith <joe at smittys.pointclark.net>

Should probably include Uwe as well, for the do_ram_command function.
That's a very nice little bit of code.

Other than that, looks good.

As far as the boot issue goes, can you drop into i82801xx_pci.c and put
in printks where pci_init() starts and ends, something like "entering
pci_init()" and "leaving pci_init()", and see what happens? I also see
i82801db has ".ops_pci          = 0," in the pci_driver struct, but that
shouldn't affect anything (just setting subsystem IDs, I think). And try
commenting out that block of code with the note about the i82801er
commenting it out as well.  I'll try to look into this further over the
weekend, see what I can come up with.


More information about the coreboot mailing list