[LinuxBIOS] [PATCH] flashrom: prepare for upcoming massive SPI chip support

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Dec 17 15:36:51 CET 2007


On 17.12.2007 14:54, Ward Vandewege wrote:
> On Mon, Dec 17, 2007 at 01:14:35AM +0100, Carl-Daniel Hailfinger wrote:
>   
>> To make it easier to add new SPI chips to flashchips.c, rename functions
>> with multiple possible opcodes from linear numbering at the end (_1, _2)
>> to include the opcode at the end (_60, _c7). That way, you only have to
>> take a short look at the data sheet and choose the right function by
>> appending the opcode listed in the data sheet.
>> No functional changes.
>>     
>
> I like how this makes the code easier to understand.
>
>   
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
>
> Acked-by: Ward Vandewege <ward at gnu.org>
>   
Thanks, r3009.

Regards,
Carl-Daniel




More information about the coreboot mailing list