[LinuxBIOS] patch to lib/console.c

ron minnich rminnich at gmail.com
Thu Dec 13 01:46:32 CET 2007


On Dec 12, 2007 4:42 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 11.12.2007 02:38, ron minnich wrote:
> > Add a nice pretty banner printer so we have standard banners.
> >
>
> Maybe make the banner a little bit shorter so bigger strings will fit
> without wrapping?

Sure! what's a good length? 20 chars?

>
> > Make 'halt' just put out nulls forever instead of hlt(), to ensure that any fifos
> > of any sort get flushed. This change also helps JTAG debuggers since it can be very
> > hard to get out of a halt instruction, but very easy to get out of an IO loop.
> > I have direct experience with this latter situation :-)
> >
> > Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
> >
>
> Using banner() in halt() would flush the fifo as well.
> Can we use inb(0x80) in the loop instead? That way, we still have an IO
> loop, but that loop will not flood the receiver. Plus, it will work much
> more nicely with my soon to come printk buffer patches.

well, is the banner enough to flush all the fifo's? I thought they got
pretty big nowadays. Anyone know?

Hey, carl-daniel, what's a good payload for testing my 'payload won't
work' problem? Also, I wonder if it is because the payload runs above
0x100000?

ron




More information about the coreboot mailing list