[LinuxBIOS] patch to lib/console.c

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Dec 13 01:42:20 CET 2007

On 11.12.2007 02:38, ron minnich wrote:
> Add a nice pretty banner printer so we have standard banners. 

Maybe make the banner a little bit shorter so bigger strings will fit
without wrapping?

> Make 'halt' just put out nulls forever instead of hlt(), to ensure that any fifos
> of any sort get flushed. This change also helps JTAG debuggers since it can be very 
> hard to get out of a halt instruction, but very easy to get out of an IO loop.
> I have direct experience with this latter situation :-)
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>

Using banner() in halt() would flush the fifo as well.
Can we use inb(0x80) in the loop instead? That way, we still have an IO
loop, but that loop will not flood the receiver. Plus, it will work much
more nicely with my soon to come printk buffer patches.


More information about the coreboot mailing list