[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD

Furquan Shaikh (Code Review) gerrit at coreboot.org
Sat Sep 29 17:05:22 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/28797


Change subject: mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD
......................................................................

mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD

This change uses the generic device driver to provide DMIC properties
in ACPI table to the OS driver.

BUG=b:112888584

Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
2 files changed, 13 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/28797/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index df59c5e..e757822 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -3,6 +3,7 @@
 	def_bool n
 	select BOARD_ROMSIZE_KB_16384
 	select DRIVERS_GENERIC_GPIO_KEYS
+	select DRIVERS_GENERIC_GENERIC
 	select DRIVERS_I2C_GENERIC
 	select DRIVERS_I2C_HID
 	select EC_GOOGLE_CHROMEEC
diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 70a379c..87219f2 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -437,7 +437,18 @@
 		end # LPC Interface
 		device pci 1f.1 on  end # P2SB
 		device pci 1f.2 on  end # Power Management Controller
-		device pci 1f.3 on  end # Intel HDA
+		device pci 1f.3 on
+			chip drivers/generic/generic
+				register "hid" = ""DMIC""
+				register "name" = ""DMIC""
+				register "desc" = ""Generic DMIC""
+				register "property_count" = "1"
+				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
+				register "property_list[0].name" = ""modeswitch_delay_ms""
+				register "property_list[0].integer" = "35"
+				device generic 0 on end
+			end
+		end # Intel HDA
 		device pci 1f.4 on  end # SMBus
 		device pci 1f.5 on  end # PCH SPI
 		device pci 1f.6 off end # GbE

-- 
To view, visit https://review.coreboot.org/28797
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e
Gerrit-Change-Number: 28797
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180929/80f4d463/attachment-0001.html>


More information about the coreboot-gerrit mailing list