<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28797">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nocturne: Add DMIC properties to ACPI DSD<br><br>This change uses the generic device driver to provide DMIC properties<br>in ACPI table to the OS driver.<br><br>BUG=b:112888584<br><br>Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/Kconfig<br>M src/mainboard/google/poppy/variants/nocturne/devicetree.cb<br>2 files changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/28797/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig</span><br><span>index df59c5e..e757822 100644</span><br><span>--- a/src/mainboard/google/poppy/Kconfig</span><br><span>+++ b/src/mainboard/google/poppy/Kconfig</span><br><span>@@ -3,6 +3,7 @@</span><br><span>   def_bool n</span><br><span>   select BOARD_ROMSIZE_KB_16384</span><br><span>        select DRIVERS_GENERIC_GPIO_KEYS</span><br><span style="color: hsl(120, 100%, 40%);">+      select DRIVERS_GENERIC_GENERIC</span><br><span>       select DRIVERS_I2C_GENERIC</span><br><span>   select DRIVERS_I2C_HID</span><br><span>       select EC_GOOGLE_CHROMEEC</span><br><span>diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>index 70a379c..87219f2 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb</span><br><span>@@ -437,7 +437,18 @@</span><br><span>                end # LPC Interface</span><br><span>          device pci 1f.1 on  end # P2SB</span><br><span>               device pci 1f.2 on  end # Power Management Controller</span><br><span style="color: hsl(0, 100%, 40%);">-           device pci 1f.3 on  end # Intel HDA</span><br><span style="color: hsl(120, 100%, 40%);">+           device pci 1f.3 on</span><br><span style="color: hsl(120, 100%, 40%);">+                    chip drivers/generic/generic</span><br><span style="color: hsl(120, 100%, 40%);">+                          register "hid" = ""DMIC""</span><br><span style="color: hsl(120, 100%, 40%);">+                               register "name" = ""DMIC""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "desc" = ""Generic DMIC""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "property_count" = "1"</span><br><span style="color: hsl(120, 100%, 40%);">+                           register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"</span><br><span style="color: hsl(120, 100%, 40%);">+                         register "property_list[0].name" = ""modeswitch_delay_ms""</span><br><span style="color: hsl(120, 100%, 40%);">+                              register "property_list[0].integer" = "35"</span><br><span style="color: hsl(120, 100%, 40%);">+                                device generic 0 on end</span><br><span style="color: hsl(120, 100%, 40%);">+                       end</span><br><span style="color: hsl(120, 100%, 40%);">+           end # Intel HDA</span><br><span>              device pci 1f.4 on  end # SMBus</span><br><span>              device pci 1f.5 on  end # PCH SPI</span><br><span>            device pci 1f.6 off end # GbE</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28797">change 28797</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28797"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I239f571bc29f02793f017a4713b5af03b23cfa3e </div>
<div style="display:none"> Gerrit-Change-Number: 28797 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>