[coreboot-gerrit] Change in coreboot[master]: libpayload/drivers/usb/uhci: Fix regression

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23686 )

Change subject: libpayload/drivers/usb/uhci: Fix regression
......................................................................


Patch Set 3:

(9 comments)

https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c
File payloads/libpayload/drivers/usb/uhci.c:

https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@346
PS3, Line 346: 			maxlen (min (mlen, len)) << TD_MAXLEN_SHIFT |
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@346
PS3, Line 346: 			maxlen (min (mlen, len)) << TD_MAXLEN_SHIFT |
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@436
PS3, Line 436: 		fill_schedule (&tds[i], ep, min (size, maxpsize), buf,
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@436
PS3, Line 436: 		fill_schedule (&tds[i], ep, min (size, maxpsize), buf,
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@443
PS3, Line 443: 	UHCI_INST (ep->dev->controller)->qh_data->elementlinkptr =
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@444
PS3, Line 444: 		virt_to_phys (tds) & ~(FLISTP_QH | FLISTP_TERMINATE);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@445
PS3, Line 445: 	td_t *td = wait_for_completed_qh (ep->dev->controller,
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@446
PS3, Line 446: 				      UHCI_INST (ep->dev->controller)->qh_data);
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/23686/3/payloads/libpayload/drivers/usb/uhci.c@448
PS3, Line 448: 		td_dump (td);
space prohibited between function name and open parenthesis '('



-- 
To view, visit https://review.coreboot.org/23686
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I823521e24f6f9e04c86d36fda751c449cd884ce3
Gerrit-Change-Number: 23686
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 28 Sep 2018 13:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180928/46f5213a/attachment.html>