[coreboot-gerrit] Change in coreboot[master]: WIP: generic: Add generic DMIC driver

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28778 )

Change subject: WIP: generic: Add generic DMIC driver
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/28778/1/src/drivers/generic/dmic/chip.h
File src/drivers/generic/dmic/chip.h:

https://review.coreboot.org/#/c/28778/1/src/drivers/generic/dmic/chip.h@8
PS1, Line 8: 	unsigned modeswitch_delay_ms;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/28778/1/src/drivers/generic/dmic/dmic.c
File src/drivers/generic/dmic/dmic.c:

https://review.coreboot.org/#/c/28778/1/src/drivers/generic/dmic/dmic.c@52
PS1, Line 52: 	acpi_dp_add_integer(dp, "modeswitch_delay_ms", config->modeswitch_delay_ms);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28778
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c8be1aa04e8d35ad4827d81a37ee54c25dfc63
Gerrit-Change-Number: 28778
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: HARSHAPRIYA N <harshapriya.n at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 28 Sep 2018 01:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180928/bdf8c4fe/attachment.html>