[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Create gnvs entries for AOAC devices
Marshall Dawson (Code Review)
gerrit at coreboot.org
Thu Sep 27 22:57:56 CEST 2018
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28765 )
Change subject: amd/stoneyridge: Create gnvs entries for AOAC devices
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/acpi/globalnvs.asl
File src/soc/amd/stoneyridge/acpi/globalnvs.asl:
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/acpi/globalnvs.asl@50
PS1, Line 50: , 5, // 0x31 - AOAC Device Enables
> Do we want to pad this to a dword boundary?
Same thoughts as in the other patch. Except for appearance, I don't think it would do much for us.
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/include/soc/southbridge.h
File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@404
PS1, Line 404: int
> uint32_t?
Hmm, I seem to recall int is proper for declaring n:m but I could be wrong. I've seen some examples of unsigned on the interwebs.
--
To view, visit https://review.coreboot.org/28765
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40f0161cc0bbc574ad703e34278372f2504de100
Gerrit-Change-Number: 28765
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 20:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/97e4fd48/attachment.html>
More information about the coreboot-gerrit
mailing list