<p><a href="https://review.coreboot.org/28765">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/acpi/globalnvs.asl">File src/soc/amd/stoneyridge/acpi/globalnvs.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/acpi/globalnvs.asl@50">Patch Set #1, Line 50:</a> <code style="font-family:monospace,monospace">   , 5,            // 0x31 - AOAC Device Enables</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Do we want to pad this to a dword boundary?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same thoughts as in the other patch.  Except for appearance, I don't think it would do much for us.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/include/soc/southbridge.h">File src/soc/amd/stoneyridge/include/soc/southbridge.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28765/1/src/soc/amd/stoneyridge/include/soc/southbridge.h@404">Patch Set #1, Line 404:</a> <code style="font-family:monospace,monospace">int</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">uint32_t?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hmm, I seem to recall int is proper for declaring n:m but I could be wrong.  I've seen some examples of unsigned on the interwebs.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28765">change 28765</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28765"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I40f0161cc0bbc574ad703e34278372f2504de100 </div>
<div style="display:none"> Gerrit-Change-Number: 28765 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-CC: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 27 Sep 2018 20:57:56 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>