[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Load AOAC and USB gnvs values

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28767 )

Change subject: amd/stoneyridge: Load AOAC and USB gnvs values
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.c@910
PS1, Line 910: 	sd = dev_find_slot(0, SD_DEVFN);
             : 
> Use is_aoac_device_enabled(FCH_AOAC_D3_STATE_SD), declaring FCH_AOAC_D3_STATE_SD = 0x70
Sorry, 0x71 is the state


https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.c@912
PS1, Line 912: 	sata = dev_find_slot(0, SATA_DEVFN);
             : 
> Use is_aoac_device_enabled(FCH_AOAC_D3_STATE_SATA), declaring FCH_AOAC_D3_STATE_SATA = 0x5E
Sorry, 0x5F is the state


https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.c@914
PS1, Line 914: 1;
> Can you be sure it'll be enabled? ESPI is not the same as SPI. […]
Sorry, 0x77 is the state



-- 
To view, visit https://review.coreboot.org/28767
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8af69c030eb2353ad75beeb2bfd3bef24abff04c
Gerrit-Change-Number: 28767
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 16:56:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/a6804de3/attachment.html>