[coreboot-gerrit] Change in coreboot[master]: soc/intel/commom/block/i2c: Make I2C controller out of reset

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/28762


Change subject: soc/intel/commom/block/i2c: Make I2C controller out of reset
......................................................................

soc/intel/commom/block/i2c: Make I2C controller out of reset

This patch ensures I2C controllers are out of reset without any
assumptions.

BUG=b:116191230
BRANCH=none
TEST=Dump MMIO offset 0x204 to check if I2C host controller is NOT
at reset (by reading Bit 0-1 as 3)

Change-Id: I4b335a834333e01cfa2d802e4aad0735d0212dcc
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/soc/intel/common/block/i2c/i2c.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/28762/1

diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c
index 11bd018..917a060 100644
--- a/src/soc/intel/common/block/i2c/i2c.c
+++ b/src/soc/intel/common/block/i2c/i2c.c
@@ -1,7 +1,7 @@
 /*
  * This file is part of the coreboot project.
  *
- * Copyright 2017 Intel Corporation.
+ * Copyright 2017-2018 Intel Corporation.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -140,8 +140,11 @@
 
 	/* dev -> bar0 */
 	res = find_resource(dev, PCI_BASE_ADDRESS_0);
-	if (res)
+	if (res) {
+		/* Take device out of reset */
+		lpss_reset_release(res->base);
 		return res->base;
+	}
 
 	return (uintptr_t)NULL;
 }

-- 
To view, visit https://review.coreboot.org/28762
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b335a834333e01cfa2d802e4aad0735d0212dcc
Gerrit-Change-Number: 28762
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/f97cfcca/attachment.html>