<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28762">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/commom/block/i2c: Make I2C controller out of reset<br><br>This patch ensures I2C controllers are out of reset without any<br>assumptions.<br><br>BUG=b:116191230<br>BRANCH=none<br>TEST=Dump MMIO offset 0x204 to check if I2C host controller is NOT<br>at reset (by reading Bit 0-1 as 3)<br><br>Change-Id: I4b335a834333e01cfa2d802e4aad0735d0212dcc<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/soc/intel/common/block/i2c/i2c.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/28762/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c</span><br><span>index 11bd018..917a060 100644</span><br><span>--- a/src/soc/intel/common/block/i2c/i2c.c</span><br><span>+++ b/src/soc/intel/common/block/i2c/i2c.c</span><br><span>@@ -1,7 +1,7 @@</span><br><span> /*</span><br><span>  * This file is part of the coreboot project.</span><br><span>  *</span><br><span style="color: hsl(0, 100%, 40%);">- * Copyright 2017 Intel Corporation.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright 2017-2018 Intel Corporation.</span><br><span>  *</span><br><span>  * This program is free software; you can redistribute it and/or modify</span><br><span>  * it under the terms of the GNU General Public License as published by</span><br><span>@@ -140,8 +140,11 @@</span><br><span> </span><br><span>    /* dev -> bar0 */</span><br><span>         res = find_resource(dev, PCI_BASE_ADDRESS_0);</span><br><span style="color: hsl(0, 100%, 40%);">-   if (res)</span><br><span style="color: hsl(120, 100%, 40%);">+      if (res) {</span><br><span style="color: hsl(120, 100%, 40%);">+            /* Take device out of reset */</span><br><span style="color: hsl(120, 100%, 40%);">+                lpss_reset_release(res->base);</span><br><span>            return res->base;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span>        return (uintptr_t)NULL;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28762">change 28762</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28762"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4b335a834333e01cfa2d802e4aad0735d0212dcc </div>
<div style="display:none"> Gerrit-Change-Number: 28762 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>