[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Activate clock center spreading depth for PTN3460

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28761 )

Change subject: siemens/mc_apl1: Activate clock center spreading depth for PTN3460
......................................................................


Patch Set 1:

(7 comments)

https://review.coreboot.org/#/c/28761/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@7
PS1, Line 7: center
clock spreading is a more common wording for that feature.


https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@7
PS1, Line 7: depth
ratio


https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@10
PS1, Line 10: depth 
ratio


https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@10
PS1, Line 10: clock frequency center spreading
I would prefere "clock spreading" here


https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@9
PS1, Line 9: from PTN3460
           : bridge device
on the LVDS interface driven by PTN3460


https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@11
PS1, Line 11: depth
ratio


https://review.coreboot.org/#/c/28761/1//COMMIT_MSG@12
PS1, Line 12: modulation
change to"nominal" here as the clock is modulated...and the modulation ratio is 1% of the nominal frequency.



-- 
To view, visit https://review.coreboot.org/28761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie457fcdbb6239dc0b25e2c35ad7a310ee80383f9
Gerrit-Change-Number: 28761
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 27 Sep 2018 10:33:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/cdd8d1c3/attachment.html>