[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Touchpad I2C CLK over spec

Chris Zhou (Code Review) gerrit at coreboot.org
Thu Sep 27 09:29:21 CEST 2018


Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/28760


Change subject: mb/google/octopus: Touchpad I2C CLK over spec
......................................................................

mb/google/octopus: Touchpad I2C CLK over spec

Need to tune I2C bus 6 clock frequency under the 400K Hz

Bug=b:115600671
TEST=flash coreboot to the DUT and measure I2C bus 6 clock
frequency whether arrive to 398.07K Hz

Change-Id: I5cc1f67f0db0553cb8424f81408ed4686cddb2fb
Signed-off-by: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/fleex/overridetree.cb
1 file changed, 41 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/28760/1

diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb
index 179b8f4..792e057 100644
--- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb
@@ -1,5 +1,46 @@
 chip soc/intel/apollolake
 
+	# Intel Common SoC Config
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| I2C5              | Audio                     |
+	#| I2C6              | Trackpad                  |
+	#| I2C7              | Touchscreen               |
+	#+-------------------+---------------------------+
+
+	register "common_soc_config" = "{
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 152,
+			.fall_time_ns = 30,
+		},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 104,
+			.fall_time_ns = 52,
+		},
+		.i2c[6] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 66,
+			.fall_time_ns = 90,
+			.data_hold_time_ns = 350,
+		},
+		.i2c[7] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 76,
+			.fall_time_ns = 164,
+		},
+	}"
+
 	device domain 0 on
 		device pci 16.1 off  end	# - I2C 1
 		device pci 17.1 on

-- 
To view, visit https://review.coreboot.org/28760
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cc1f67f0db0553cb8424f81408ed4686cddb2fb
Gerrit-Change-Number: 28760
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/db2d1ee6/attachment-0001.html>


More information about the coreboot-gerrit mailing list