[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Define a sync IRQ if needed
Duncan Laurie (Code Review)
gerrit at coreboot.org
Wed Sep 26 23:56:42 CEST 2018
Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/28758
Change subject: ec/google/chromeec: Define a sync IRQ if needed
......................................................................
ec/google/chromeec: Define a sync IRQ if needed
Some boards are adding a second pin used for synchronization between
the EC and AP. This is a direct connection between the EC and the SOC
that is intended to provide a lower latency interrupt signal for
sensors on the EC.
Currently the runtime EC interrupts assert an SCI before eventually
resulting in a Notify() on the MKBP device that the sensor driver users.
These extra layers add processing time and require additional EC
communication to determine the event source.
This interface was tested on a reworked Nocturne board with modified
EC and a modified kernel driver to ensure that the interrupt asserts
as expected and can be used by the kernel driver.
Change-Id: I49a11363ce82882e572bcb8923fd114ab6593fea
Signed-off-by: Duncan Laurie <dlaurie at google.com>
---
M src/ec/google/chromeec/acpi/cros_ec.asl
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/28758/1
diff --git a/src/ec/google/chromeec/acpi/cros_ec.asl b/src/ec/google/chromeec/acpi/cros_ec.asl
index d0a5b68..befd5a7 100644
--- a/src/ec/google/chromeec/acpi/cros_ec.asl
+++ b/src/ec/google/chromeec/acpi/cros_ec.asl
@@ -22,6 +22,16 @@
Name (_PRW, Package () { EC_ENABLE_WAKE_PIN, 0x5 })
#endif
+#ifdef EC_ENABLE_SYNC_IRQ
+ Name (_CRS, ResourceTemplate ()
+ {
+ Interrupt (ResourceConsumer, Edge, ActiveLow, Exclusive)
+ {
+ EC_SYNC_IRQ
+ }
+ })
+#endif
+
#ifdef EC_ENABLE_MKBP_DEVICE
Device (CKSC)
{
--
To view, visit https://review.coreboot.org/28758
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49a11363ce82882e572bcb8923fd114ab6593fea
Gerrit-Change-Number: 28758
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180926/d5c59768/attachment-0001.html>
More information about the coreboot-gerrit
mailing list