[coreboot-gerrit] Change in coreboot[master]: src/mainboard/pcengines/apu2/Kconfig: Clean up PINMUX settings

Michał Żygowski (Code Review) gerrit at coreboot.org
Mon Sep 24 13:46:30 CEST 2018


Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/28720


Change subject: src/mainboard/pcengines/apu2/Kconfig: Clean up PINMUX settings
......................................................................

src/mainboard/pcengines/apu2/Kconfig: Clean up PINMUX settings

Vendor recommendations related to PINMUX configuration are UARTs.
Given that PINMUX_UART_x can be set for all boards as default.

Change-Id: Ifb7dfe23a95ba0e572adc38212333d9fdd234d53
Signed-off-by: Michał Żygowski <michal.zygowski at 3mdeb.com>
---
M src/mainboard/pcengines/apu2/Kconfig
1 file changed, 2 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/28720/1

diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig
index af14066..3d2ed0c 100644
--- a/src/mainboard/pcengines/apu2/Kconfig
+++ b/src/mainboard/pcengines/apu2/Kconfig
@@ -78,9 +78,7 @@
 
 choice
 	prompt "J19 pins 1-10"
-	default APU2_PINMUX_OFF_C if BOARD_PCENGINES_APU2 || \
-		BOARD_PCENGINES_APU3 || BOARD_PCENGINES_APU4
-	default APU2_PINMUX_UART_C if BOARD_PCENGINES_APU5
+	default APU2_PINMUX_UART_C
 
 config APU2_PINMUX_OFF_C
 	bool "disable"
@@ -97,9 +95,7 @@
 
 choice
 	prompt "J19 pins 11-20"
-	default APU2_PINMUX_OFF_D if BOARD_PCENGINES_APU2 || \
-		BOARD_PCENGINES_APU3 || BOARD_PCENGINES_APU4
-	default APU2_PINMUX_UART_D if BOARD_PCENGINES_APU5
+	default APU2_PINMUX_UART_D
 
 config APU2_PINMUX_OFF_D
 	bool "disable"

-- 
To view, visit https://review.coreboot.org/28720
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb7dfe23a95ba0e572adc38212333d9fdd234d53
Gerrit-Change-Number: 28720
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180924/b7156e29/attachment.html>


More information about the coreboot-gerrit mailing list