[coreboot-gerrit] Change in coreboot[master]: sb/amd: Use 'unsigned int' to bare use of 'unsigned'
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Sep 21 11:43:33 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28709 )
Change subject: sb/amd: Use 'unsigned int' to bare use of 'unsigned'
......................................................................
Patch Set 1:
(11 comments)
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h
File src/southbridge/amd/amd8111/amd8111_smbus.h:
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@66
PS1, Line 66: static int do_smbus_recv_byte(unsigned smbus_io_base, unsigned int device)
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@112
PS1, Line 112: static int do_smbus_send_byte(unsigned smbus_io_base, unsigned int device,
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@113
PS1, Line 113: unsigned value)
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@155
PS1, Line 155: static int do_smbus_read_byte(unsigned smbus_io_base, unsigned int device,
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@202
PS1, Line 202: static int do_smbus_write_byte(unsigned smbus_io_base, unsigned int device,
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@241
PS1, Line 241: static int do_smbus_block_read(unsigned smbus_io_base, unsigned int device,
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@242
PS1, Line 242: unsigned cmd, u8 bytes, u8 *buf)
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@298
PS1, Line 298: static int do_smbus_block_write(unsigned smbus_io_base, unsigned int device,
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@299
PS1, Line 299: unsigned cmd, u8 bytes, const u8 *buf)
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_smbus.c
File src/southbridge/amd/amd8111/early_smbus.c:
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_smbus.c@63
PS1, Line 63: static inline int smbus_block_read(unsigned int device, unsigned cmd, u8 bytes,
Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_smbus.c@69
PS1, Line 69: static inline int smbus_block_write(unsigned int device, unsigned cmd, u8 bytes,
Prefer 'unsigned int' to bare use of 'unsigned'
--
To view, visit https://review.coreboot.org/28709
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I05f9ea97ea80ac7a8f34845c59bd66e424ba2991
Gerrit-Change-Number: 28709
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Sep 2018 09:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180921/931ff2f8/attachment.html>
More information about the coreboot-gerrit
mailing list