<p><a href="https://review.coreboot.org/28709">View Change</a></p><p>11 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h">File src/southbridge/amd/amd8111/amd8111_smbus.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@66">Patch Set #1, Line 66:</a> <code style="font-family:monospace,monospace">static int do_smbus_recv_byte(unsigned smbus_io_base, unsigned int device)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@112">Patch Set #1, Line 112:</a> <code style="font-family:monospace,monospace">static int do_smbus_send_byte(unsigned smbus_io_base, unsigned int device,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@113">Patch Set #1, Line 113:</a> <code style="font-family:monospace,monospace">                       unsigned value)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@155">Patch Set #1, Line 155:</a> <code style="font-family:monospace,monospace">static int do_smbus_read_byte(unsigned smbus_io_base, unsigned int device,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@202">Patch Set #1, Line 202:</a> <code style="font-family:monospace,monospace">static int do_smbus_write_byte(unsigned smbus_io_base, unsigned int device,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@241">Patch Set #1, Line 241:</a> <code style="font-family:monospace,monospace">static int do_smbus_block_read(unsigned smbus_io_base, unsigned int device,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@242">Patch Set #1, Line 242:</a> <code style="font-family:monospace,monospace">                              unsigned cmd, u8 bytes, u8 *buf)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@298">Patch Set #1, Line 298:</a> <code style="font-family:monospace,monospace">static int do_smbus_block_write(unsigned smbus_io_base, unsigned int device,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/amd8111_smbus.h@299">Patch Set #1, Line 299:</a> <code style="font-family:monospace,monospace">                           unsigned cmd, u8 bytes, const u8 *buf)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_smbus.c">File src/southbridge/amd/amd8111/early_smbus.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_smbus.c@63">Patch Set #1, Line 63:</a> <code style="font-family:monospace,monospace">static inline int smbus_block_read(unsigned int device, unsigned cmd, u8 bytes,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28709/1/src/southbridge/amd/amd8111/early_smbus.c@69">Patch Set #1, Line 69:</a> <code style="font-family:monospace,monospace">static inline int smbus_block_write(unsigned int device, unsigned cmd, u8 bytes,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Prefer 'unsigned int' to bare use of 'unsigned'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28709">change 28709</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28709"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I05f9ea97ea80ac7a8f34845c59bd66e424ba2991 </div>
<div style="display:none"> Gerrit-Change-Number: 28709 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Elyes HAOUAS <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 21 Sep 2018 09:43:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>