[coreboot-gerrit] Change in coreboot[master]: soc/sifive/fu540: Document #if ENV_ROMSTAGE line
Jonathan Neuschäfer (Code Review)
gerrit at coreboot.org
Thu Sep 20 17:18:26 CEST 2018
Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28699
Change subject: soc/sifive/fu540: Document #if ENV_ROMSTAGE line
......................................................................
soc/sifive/fu540: Document #if ENV_ROMSTAGE line
Change-Id: Idcd72c558e46637b1b99e9613963436fedd4a8b9
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M src/soc/sifive/fu540/clock.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/28699/1
diff --git a/src/soc/sifive/fu540/clock.c b/src/soc/sifive/fu540/clock.c
index eb7a8b5..20dce23 100644
--- a/src/soc/sifive/fu540/clock.c
+++ b/src/soc/sifive/fu540/clock.c
@@ -121,8 +121,8 @@
// 33.33 Mhz after reset
#define FU540_BASE_FQY 33330
+/* Clock initialization should only be done in romstage. */
#if ENV_ROMSTAGE
-
static void init_coreclk(void)
{
// switch coreclk to input reference frequency before modifying PLL
@@ -240,8 +240,7 @@
for (int i = 0; i < 256; i++)
asm volatile ("nop");
}
-
-#endif
+#endif /* ENV_ROMSTAGE */
int clock_get_coreclk_khz(void)
{
--
To view, visit https://review.coreboot.org/28699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcd72c558e46637b1b99e9613963436fedd4a8b9
Gerrit-Change-Number: 28699
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180920/416d0727/attachment.html>
More information about the coreboot-gerrit
mailing list