[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Pha...

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Sep 19 18:17:28 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 )

Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaseer
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variants/phaser/gpio.c
File src/mainboard/google/octopus/variants/phaser/gpio.c:

https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variants/phaser/gpio.c@64
PS8, Line 64: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),
line over 80 characters


https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variants/phaser/gpio.c@107
PS8, Line 107: 	}else
space required after that close brace '}'



-- 
To view, visit https://review.coreboot.org/28669
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666
Gerrit-Change-Number: 28669
Gerrit-PatchSet: 8
Gerrit-Owner: Peichao Li <peichao.wang at bitland.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jett Rink <jettrink at google.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 19 Sep 2018 16:17:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180919/33933251/attachment.html>


More information about the coreboot-gerrit mailing list