<p><a href="https://review.coreboot.org/28669">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variants/phaser/gpio.c">File src/mainboard/google/octopus/variants/phaser/gpio.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variants/phaser/gpio.c@64">Patch Set #8, Line 64:</a> <code style="font-family:monospace,monospace">        PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">line over 80 characters</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variants/phaser/gpio.c@107">Patch Set #8, Line 107:</a> <code style="font-family:monospace,monospace">    }else</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space required after that close brace '}'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28669">change 28669</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28669"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666 </div>
<div style="display:none"> Gerrit-Change-Number: 28669 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jett Rink <jettrink@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 19 Sep 2018 16:17:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>