[coreboot-gerrit] Change in coreboot[master]: google/kukui: Set up EC_IN_RW GPIO for ChromeOS

[Tristan Hsieh (Code Review)]

Tristan Hsieh has uploaded this change for review. ( https://review.coreboot.org/28670


Change subject: google/kukui: Set up EC_IN_RW GPIO for ChromeOS
......................................................................

google/kukui: Set up EC_IN_RW GPIO for ChromeOS

Set up EC_IN_RW GPIO to boot depthcharge. Without this patch,
depthcharge will fail to tell if the EC firmware is RW.

BUG=b:80501386
BRANCH=none
TEST=Boots correctly on Kukui and see in logs, that depthcharge detects
     EC_IN_RW GPIO.

Change-Id: Icb39d663f65b72e0ad54059c9590d9693106ee25
Signed-off-by: Tristan Shieh <tristan.shieh at mediatek.com>
---
M src/mainboard/google/kukui/chromeos.c
M src/mainboard/google/kukui/gpio.h
2 files changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/28670/1

diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c
index 9184d88..bb14b1c 100644
--- a/src/mainboard/google/kukui/chromeos.c
+++ b/src/mainboard/google/kukui/chromeos.c
@@ -21,12 +21,14 @@
 
 void setup_chromeos_gpios(void)
 {
+	gpio_input_pullup(EC_IN_RW);
 	gpio_input_pullup(EC_IRQ);
 }
 
 void fill_lb_gpios(struct lb_gpios *gpios)
 {
 	struct lb_gpio chromeos_gpios[] = {
+		{EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"},
 		{EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"},
 	};
 	lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
diff --git a/src/mainboard/google/kukui/gpio.h b/src/mainboard/google/kukui/gpio.h
index cb9ad24..a2f7760 100644
--- a/src/mainboard/google/kukui/gpio.h
+++ b/src/mainboard/google/kukui/gpio.h
@@ -18,7 +18,8 @@
 
 #include <soc/gpio.h>
 
-#define EC_IRQ	GPIO(PERIPHERAL_EN1)
+#define EC_IRQ		GPIO(PERIPHERAL_EN1)
+#define EC_IN_RW	GPIO(PERIPHERAL_EN14)
 
 void setup_chromeos_gpios(void);
 

-- 
To view, visit https://review.coreboot.org/28670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb39d663f65b72e0ad54059c9590d9693106ee25
Gerrit-Change-Number: 28670
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh <tristan.shieh at mediatek.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180919/b738477f/attachment.html>