<p>Tristan Hsieh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28670">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/kukui: Set up EC_IN_RW GPIO for ChromeOS<br><br>Set up EC_IN_RW GPIO to boot depthcharge. Without this patch,<br>depthcharge will fail to tell if the EC firmware is RW.<br><br>BUG=b:80501386<br>BRANCH=none<br>TEST=Boots correctly on Kukui and see in logs, that depthcharge detects<br>     EC_IN_RW GPIO.<br><br>Change-Id: Icb39d663f65b72e0ad54059c9590d9693106ee25<br>Signed-off-by: Tristan Shieh <tristan.shieh@mediatek.com><br>---<br>M src/mainboard/google/kukui/chromeos.c<br>M src/mainboard/google/kukui/gpio.h<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/28670/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kukui/chromeos.c b/src/mainboard/google/kukui/chromeos.c</span><br><span>index 9184d88..bb14b1c 100644</span><br><span>--- a/src/mainboard/google/kukui/chromeos.c</span><br><span>+++ b/src/mainboard/google/kukui/chromeos.c</span><br><span>@@ -21,12 +21,14 @@</span><br><span> </span><br><span> void setup_chromeos_gpios(void)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+  gpio_input_pullup(EC_IN_RW);</span><br><span>         gpio_input_pullup(EC_IRQ);</span><br><span> }</span><br><span> </span><br><span> void fill_lb_gpios(struct lb_gpios *gpios)</span><br><span> {</span><br><span>       struct lb_gpio chromeos_gpios[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+           {EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"},</span><br><span>                {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"},</span><br><span>       };</span><br><span>   lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));</span><br><span>diff --git a/src/mainboard/google/kukui/gpio.h b/src/mainboard/google/kukui/gpio.h</span><br><span>index cb9ad24..a2f7760 100644</span><br><span>--- a/src/mainboard/google/kukui/gpio.h</span><br><span>+++ b/src/mainboard/google/kukui/gpio.h</span><br><span>@@ -18,7 +18,8 @@</span><br><span> </span><br><span> #include <soc/gpio.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define EC_IRQ      GPIO(PERIPHERAL_EN1)</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_IRQ            GPIO(PERIPHERAL_EN1)</span><br><span style="color: hsl(120, 100%, 40%);">+#define EC_IN_RW  GPIO(PERIPHERAL_EN14)</span><br><span> </span><br><span> void setup_chromeos_gpios(void);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28670">change 28670</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28670"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icb39d663f65b72e0ad54059c9590d9693106ee25 </div>
<div style="display:none"> Gerrit-Change-Number: 28670 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Tristan Hsieh <tristan.shieh@mediatek.com> </div>