[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: EMMC reset needs to be output low

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28649


Change subject: mainboard/google/kahlee:  EMMC reset needs to be output low
......................................................................

mainboard/google/kahlee:  EMMC reset needs to be output low

While the pin was set to a pull-down, with the external pull-up, this
wasn't enough to keep the pin low.  Set to output low to drive to 0V.

TEST=Boot grunt, verify EMMC_BRIDGE_RST is 0V.
BUG=b:115661061

Change-Id: Ife014b8a879274df5d892c1de386976808de1df0
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28649/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 75a8ab5..95064bc 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -54,7 +54,7 @@
 	PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),
 
 	/* GPIO_40 - EMMC_BRIDGE_RST */
-	PAD_GPI(GPIO_40, PULL_DOWN),
+	PAD_GPO(GPIO_40, LOW),
 
 	/* GPIO_70 - WLAN_PE_RST_L */
 	PAD_GPO(GPIO_70, HIGH),

-- 
To view, visit https://review.coreboot.org/28649
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife014b8a879274df5d892c1de386976808de1df0
Gerrit-Change-Number: 28649
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180917/bd4763ea/attachment.html>