<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/28649">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee:  EMMC reset needs to be output low<br><br>While the pin was set to a pull-down, with the external pull-up, this<br>wasn't enough to keep the pin low.  Set to output low to drive to 0V.<br><br>TEST=Boot grunt, verify EMMC_BRIDGE_RST is 0V.<br>BUG=b:115661061<br><br>Change-Id: Ife014b8a879274df5d892c1de386976808de1df0<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28649/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index 75a8ab5..95064bc 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -54,7 +54,7 @@</span><br><span>   PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),</span><br><span> </span><br><span>  /* GPIO_40 - EMMC_BRIDGE_RST */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_GPI(GPIO_40, PULL_DOWN),</span><br><span style="color: hsl(120, 100%, 40%);">+  PAD_GPO(GPIO_40, LOW),</span><br><span> </span><br><span>   /* GPIO_70 - WLAN_PE_RST_L */</span><br><span>        PAD_GPO(GPIO_70, HIGH),</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28649">change 28649</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28649"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ife014b8a879274df5d892c1de386976808de1df0 </div>
<div style="display:none"> Gerrit-Change-Number: 28649 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>