[coreboot-gerrit] Change in coreboot[master]: util/lint: Ignore "visible if" statement in Kconfig files

[Patrick Georgi (Code Review)]

Hello Alexander Couzens,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/28635

to review the following change.


Change subject: util/lint: Ignore "visible if" statement in Kconfig files
......................................................................

util/lint: Ignore "visible if" statement in Kconfig files

They allow reducing the visible set of options to remove clutter.

Change-Id: I18c953c7feae23c0752392a2bf8f49783c17310e
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/lint/kconfig_lint
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/28635/1

diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index fb8e60f..62997dd 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -682,6 +682,13 @@
             push( @inside_menu, $menu );
         }
 
+        # visible if <expr>
+        elsif ( $line =~ /^\s*visible if.*$/ ) {
+	    # Must come directly after menu line (and on a separate line)
+	    # but kconfig already checks for that.
+	    # Ignore it.
+        }
+
         # endmenu
         elsif ( $line =~ /^\s*endmenu/ ) {
             $inside_config = "";

-- 
To view, visit https://review.coreboot.org/28635
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I18c953c7feae23c0752392a2bf8f49783c17310e
Gerrit-Change-Number: 28635
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180916/b2cd19e8/attachment.html>