<p>Patrick Georgi would like Alexander Couzens to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/28635">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/lint: Ignore "visible if" statement in Kconfig files<br><br>They allow reducing the visible set of options to remove clutter.<br><br>Change-Id: I18c953c7feae23c0752392a2bf8f49783c17310e<br>Signed-off-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M util/lint/kconfig_lint<br>1 file changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/28635/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint</span><br><span>index fb8e60f..62997dd 100755</span><br><span>--- a/util/lint/kconfig_lint</span><br><span>+++ b/util/lint/kconfig_lint</span><br><span>@@ -682,6 +682,13 @@</span><br><span>             push( @inside_menu, $menu );</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        # visible if <expr></span><br><span style="color: hsl(120, 100%, 40%);">+        elsif ( $line =~ /^\s*visible if.*$/ ) {</span><br><span style="color: hsl(120, 100%, 40%);">+            # Must come directly after menu line (and on a separate line)</span><br><span style="color: hsl(120, 100%, 40%);">+         # but kconfig already checks for that.</span><br><span style="color: hsl(120, 100%, 40%);">+        # Ignore it.</span><br><span style="color: hsl(120, 100%, 40%);">+        }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>         # endmenu</span><br><span>         elsif ( $line =~ /^\s*endmenu/ ) {</span><br><span>             $inside_config = "";</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/28635">change 28635</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28635"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I18c953c7feae23c0752392a2bf8f49783c17310e </div>
<div style="display:none"> Gerrit-Change-Number: 28635 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>