[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Sync PSP base to MSR

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28608 )

Change subject: amd/stoneyridge: Sync PSP base to MSR
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I still don't see how this can have anything to do with the TPM that would be reported by coreboot.  Grunt uses a discrete TPM and not the fTPM in the PSP.
> 
> I hadn't tried S3.  However, I get a GPF on resume during mp_init when the MSR is rewritten. It's easy enough to skip it on a resume, but I'd like some direction from AMD instead of flailing like this.
Could it be that the S3 failure was actually GPF? Could it be that the MSR is preserved through S3, thus causing GPF when written again?


-- 
To view, visit https://review.coreboot.org/28608
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30027d3b0a6fbd540375e96001beb9c25bf3a678
Gerrit-Change-Number: 28608
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall at amd.corp-partner.google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Sep 2018 20:14:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180914/c5d49578/attachment.html>