[coreboot-gerrit] Change in coreboot[rampayload]: WIP: Port libpayload to riscv

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28606 )

Change subject: WIP: Port libpayload to riscv
......................................................................


Patch Set 1:

(14 comments)

https://review.coreboot.org/#/c/28606/1/payloads/external/LinuxBoot/Makefile
File payloads/external/LinuxBoot/Makefile:

https://review.coreboot.org/#/c/28606/1/payloads/external/LinuxBoot/Makefile@78
PS1, Line 78: 	echo "BEFOR DEF"
'BEFOR' may be misspelled - perhaps 'BEFORE'?


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/arch/riscv/coreboot.c
File payloads/libpayload/arch/riscv/coreboot.c:

https://review.coreboot.org/#/c/28606/1/payloads/libpayload/arch/riscv/coreboot.c@42
PS1, Line 42: 	switch(rec->tag) {
space required before the open parenthesis '('


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h
File payloads/libpayload/include/riscv/arch/asm.h:

https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@14
PS1, Line 14: #define ALIGN .align 2
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@16
PS1, Line 16: #define ENDPROC(name) \
Macros with multiple statements should be enclosed in a do - while loop


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@17
PS1, Line 17: 	.type name, %function; \
need consistent spacing around '%' (ctx:WxV)


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@20
PS1, Line 20: #define ENTRY(name) \
Macros with multiple statements should be enclosed in a do - while loop


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@21
PS1, Line 21: 	.section .text.name, "ax", %progbits; \
need consistent spacing around '%' (ctx:WxV)


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@24
PS1, Line 24: 	name:
labels should not be indented


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@26
PS1, Line 26: #define END(name) \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/asm.h@27
PS1, Line 27: 	.size name, .-name
space required before that '-' (ctx:VxV)


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/barrier.h
File payloads/libpayload/include/riscv/arch/barrier.h:

https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/barrier.h@57
PS1, Line 57: #define mb()
memory barrier without comment


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/barrier.h@58
PS1, Line 58: #define rmb()
memory barrier without comment


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/barrier.h@59
PS1, Line 59: #define wmb()
memory barrier without comment


https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/cache.h
File payloads/libpayload/include/riscv/arch/cache.h:

https://review.coreboot.org/#/c/28606/1/payloads/libpayload/include/riscv/arch/cache.h@81
PS1, Line 81: }
void function return statements are not generally useful



-- 
To view, visit https://review.coreboot.org/28606
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: rampayload
Gerrit-MessageType: comment
Gerrit-Change-Id: I91df02069a0f8fd8771f73de0e866e9cea05cded
Gerrit-Change-Number: 28606
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 14 Sep 2018 14:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180914/39943526/attachment.html>