[coreboot-gerrit] Change in coreboot[master]: mb/google/kahlee/variants/baseboard: Set STAPM percentage

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Wed Sep 12 23:28:05 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28564 )

Change subject: mb/google/kahlee/variants/baseboard: Set STAPM percentage
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/28564/3/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c
File src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c:

https://review.coreboot.org/#/c/28564/3/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c@161
PS3, Line 161: 			PlatStapmConfig.CfgStapmScalar = cfg->stapm_percent;
Avoid multiple line dereference - prefer 'InitEarly->PlatformConfig.PlatStapmConfig.CfgStapmScalar'


https://review.coreboot.org/#/c/28564/3/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c@164
PS3, Line 164: 			PlatStapmConfig.CfgStapmTimeConstant = cfg->stapm_time;
Avoid multiple line dereference - prefer 'InitEarly->PlatformConfig.PlatStapmConfig.CfgStapmTimeConstant'



-- 
To view, visit https://review.coreboot.org/28564
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22863f6ed76152bf872fce3e275f8a7fd8077504
Gerrit-Change-Number: 28564
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 12 Sep 2018 21:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180912/a7bd2298/attachment.html>


More information about the coreboot-gerrit mailing list