<p><a href="https://review.coreboot.org/28564">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/28564/3/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c">File src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28564/3/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c@161">Patch Set #3, Line 161:</a> <code style="font-family:monospace,monospace">                        PlatStapmConfig.CfgStapmScalar = cfg->stapm_percent;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoid multiple line dereference - prefer 'InitEarly->PlatformConfig.PlatStapmConfig.CfgStapmScalar'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/28564/3/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c@164">Patch Set #3, Line 164:</a> <code style="font-family:monospace,monospace">                       PlatStapmConfig.CfgStapmTimeConstant = cfg->stapm_time;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Avoid multiple line dereference - prefer 'InitEarly->PlatformConfig.PlatStapmConfig.CfgStapmTimeConstant'</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/28564">change 28564</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/28564"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I22863f6ed76152bf872fce3e275f8a7fd8077504 </div>
<div style="display:none"> Gerrit-Change-Number: 28564 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Spiegel <richard.spiegel@silverbackltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Sep 2018 21:28:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>