[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge/gpio.c: Create I2C slave reset code

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Sep 11 19:51:57 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28572

to look at the new patch set (#2).

Change subject: soc/amd/stoneyridge/gpio.c: Create I2C slave reset code
......................................................................

soc/amd/stoneyridge/gpio.c: Create I2C slave reset code

AMD soc does not wait for I2C transaction to complete before executing a
reset. Because of this, it's possible for the reset to happen in the middle
of a transaction, resulting on a slave hang. There are 2 possible solutions:
If the slave has a reset pin connected to a GPIO pin, it can be used to
reset the slave, else the only solution is to bang SCL 9 times. Create code
that makes it easy to implement either solution.

BUG=b:114479395
TEST=Build and boot grunt.

Change-Id: I9a0bc00c55ecc8ec660c74794bee48302663e72b
Signed-off-by: Richard Spiegel <richard.spiegel at silverbackltd.com>
---
M src/soc/amd/stoneyridge/gpio.c
M src/soc/amd/stoneyridge/include/soc/gpio.h
2 files changed, 108 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/28572/2
-- 
To view, visit https://review.coreboot.org/28572
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a0bc00c55ecc8ec660c74794bee48302663e72b
Gerrit-Change-Number: 28572
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180911/a2cbd7d8/attachment.html>


More information about the coreboot-gerrit mailing list