[coreboot-gerrit] Change in coreboot[master]: riscv: temporarily block multiple-threads

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27358 )

Change subject: riscv: temporarily block multiple-threads
......................................................................


Patch Set 28:

(4 comments)

https://review.coreboot.org/#/c/27358/28/src/arch/riscv/include/arch/smp/smp.h
File src/arch/riscv/include/arch/smp/smp.h:

https://review.coreboot.org/#/c/27358/28/src/arch/riscv/include/arch/smp/smp.h@62
PS28, Line 62: 		if (arrived > 1) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/27358/28/src/arch/riscv/include/arch/smp/smp.h@66
PS28, Line 66: 		while (bar->wait[gen] == 0) ;
space prohibited before semicolon


https://review.coreboot.org/#/c/27358/28/src/arch/riscv/include/arch/smp/smp.h@66
PS28, Line 66: 		while (bar->wait[gen] == 0) ;
trailing statements should be on next line


https://review.coreboot.org/#/c/27358/28/src/arch/riscv/include/arch/smp/smp.h@68
PS28, Line 68: 		if (atomic_fetch_add(&(bar->entered[gen]), -1) == 1) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/27358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0eeed51e0952c66a9a9f25a90105fe471ffa70e
Gerrit-Change-Number: 27358
Gerrit-PatchSet: 28
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Ronald G. Minnich <rminnich at gmail.com>
Gerrit-Comment-Date: Tue, 11 Sep 2018 09:37:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180911/26342795/attachment.html>