[coreboot-gerrit] Change in coreboot[master]: [WIP] new board: Dell Latitude E6230

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22693 )

Change subject: [WIP] new board: Dell Latitude E6230
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/ec.c
File src/mainboard/dell/latitude_e6230/ec.c:

https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/ec.c@89
PS4, Line 89: static int write_send(u8 *sdata, u8 c, unsigned count)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/romstage.c
File src/mainboard/dell/latitude_e6230/romstage.c:

https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/romstage.c@25
PS4, Line 25: 	pci_write_config16(PCH_LPC_DEV, LPC_EN, CNF1_LPC_EN | MC_LPC_EN | KBC_LPC_EN);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/22693
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cdc01e902e670310628809416290045c2102340
Gerrit-Change-Number: 22693
Gerrit-PatchSet: 4
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 11 Sep 2018 07:49:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180911/b8581a06/attachment.html>