[coreboot-gerrit] Change in coreboot[master]: google/grunt: Update ELAN TP/TS device ACPI nodes

Kevin Chiu (Code Review) gerrit at coreboot.org
Mon Sep 10 13:05:08 CEST 2018


Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/28548


Change subject: google/grunt: Update ELAN TP/TS device ACPI nodes
......................................................................

google/grunt: Update ELAN TP/TS device ACPI nodes

change ELAN TP/TS I2C irq to EDGE trigger to prevent any missing
in interrupt handler.

BUG=b:79996636
BRANCH=master
TEST=emerge-grunt coreboot
Change-Id: I84c193b59aaa3b068f4cdc519d902fce6fb840c7
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
M src/mainboard/google/kahlee/variants/careena/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/28548/1

diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
index 513bd4e..991e7a1 100644
--- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb
+++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb
@@ -130,7 +130,7 @@
 		chip drivers/i2c/generic
 			register "hid" = ""ELAN0000""
 			register "desc" = ""ELAN Touchpad""
-			register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_5)"
+			register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_5)"
 			register "wake" = "7"
 			device i2c 15 on end
 		end
@@ -152,7 +152,7 @@
 			register "hid" = ""ELAN0001""
 			register "desc" = ""ELAN Touchscreen""
 			register "probed" = "1"
-			register "irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_11)"
+			register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_11)"
 			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_85)"
 			register "reset_delay_ms" = "20"
 			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_76)"

-- 
To view, visit https://review.coreboot.org/28548
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c193b59aaa3b068f4cdc519d902fce6fb840c7
Gerrit-Change-Number: 28548
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180910/c8ca2e28/attachment.html>


More information about the coreboot-gerrit mailing list