[coreboot-gerrit] Change in coreboot[master]: Enabled USB Power on Leaf Hill CRB.

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28547 )

Change subject: Enabled USB Power on Leaf Hill CRB.
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpio.h
File src/mainboard/intel/leafhill/brd_gpio.h:

https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpio.h@51
PS1, Line 51:         /// Added feature to enable USB power for USB devices, specifically keyboard and mouse.
line over 80 characters


https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpio.h@51
PS1, Line 51:         /// Added feature to enable USB power for USB devices, specifically keyboard and mouse.
code indent should use tabs where possible


https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpio.h@52
PS1, Line 52:         PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH
line over 80 characters


https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpio.h@52
PS1, Line 52:         PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH
code indent should use tabs where possible


https://review.coreboot.org/#/c/28547/1/src/mainboard/intel/leafhill/brd_gpio.h@52
PS1, Line 52:         PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_23, 1, DEEP, DN_20K, TxLASTRxE, SAME), /// Feature: LB USB Power in LFH
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/28547
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I808d48789506123d544647ef3eefc0ea064d89a2
Gerrit-Change-Number: 28547
Gerrit-PatchSet: 1
Gerrit-Owner: Jose S. Cofreros Jr. <josh.cofreros at gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 10 Sep 2018 08:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180910/80bd6640/attachment.html>